Updates to the 0x contract #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomwade
commented
Sep 13, 2022
tomwade
commented
- Set swap target
- Allow zap pausing
- Set oanable
- Set reentrancy guard
- Remove passable swap target
- Cry
# Conflicts: # hardhat.config.js
- Set swap target - Allow zap pausing - Set oanable - Set reentrancy guard - Remove passable swap target - Cry
# Conflicts: # contracts/solidity/NFTXMarketplace0xZap.sol # scripts/deploy-marketplace0x-zap.js
0xKiwi
reviewed
Sep 22, 2022
| */ | ||
|
|
||
| function setSwapTarget(address payable _swapTarget) external onlyOwner { | ||
| swapTarget = _swapTarget; |
There was a problem hiding this comment.
Under what situations would this need to be changed? This means owner could steal from any approvals.
There was a problem hiding this comment.
I'll shift this to the constructor, make it immutable and update to have it factored into the deployment script 👍
0xKiwi
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.