Skip to content

FATES API refactor - BC to patch "direct" #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
glemieux wants to merge 123 commits into
base: master
Choose a base branch
from
Draft

FATES API refactor - BC to patch "direct" #17

glemieux wants to merge 123 commits into from
+317 −121

Conversation

@glemieux
Copy link

@glemieux glemieux commented May 20, 2025

No description provided.

@glemieux glemieux force-pushed the lnd/fates-bc-refactor-patch-direct branch from 1a338a0 to c6c5b78 Compare July 2, 2025 16:37
@glemieux glemieux force-pushed the lnd/fates-bc-refactor-patch-direct branch 2 times, most recently from 46dd1ae to 7e99bd1 Compare September 2, 2025 17:23
glemieux added 27 commits October 31, 2025 15:31
@glemieux
initial addition of HLM-side BC transfer subroutine
42a5363
@glemieux
adding sketch code of how to make the transfer call iterable
ae9d656
@glemieux
add patch-level transfer bc in call
961ea82
@glemieux
remove unused bc_out from init_site_vars
61b7019
@glemieux
remove unused bc_in argument from canopy_summarization
52e10d9
@glemieux
remove unneeded bc_out argument passing to Accumulatefluxes_ED
c3ade1c
@glemieux
add allocation of site-level mapping arrays
ccbe30f
@glemieux
add local variable definition for canopystate type
d1e538d
@glemieux
move mapping allocations inside site loop
63a3b5f
@glemieux
add use of transferbcin from fatesinterfacemod
aa96dcd
@glemieux
utilize type-bound bc transfer procedure
a7fe065
@glemieux
call generic transfer bc in subroutine
b71d8aa
@glemieux
remove unused fates patch type
1afa575
@glemieux
temporarily update lobata configuration
21a97a4
@glemieux
remove unused w and t scalars assignment as this is handled by the ne…
0447d91 
…w transfer function
@glemieux
change updatebcin to use the fates_interface_type for legibility and …
272c1df 
…simplicity
@glemieux
call updatebcin
fc23e8f
@glemieux
add HLM-FATES API variable mapping data structure and implement in tr…
673e4e4 
…ansfer subroutine
@glemieux
remove old bc transfer wrapper call that was accidentally left behind
9c1a89f
@glemieux
fixed deferred length character array
edd91b7
@glemieux
add new type to create an array of pointers to hlm arrays
dab9c64
@glemieux
update and move the WrapTransferBC call with new type
521c6d6
@glemieux
replace column and site map with patch index
6e4e577
@glemieux
minor typo fix
c0b8ce0
@glemieux
correct end procedure name
5354e2e
@glemieux
add missing bounds clump argument to set patch index call
5a3a317
@glemieux
Update wrap bc transfer subroutine to be bc_in specific
c17eb58
glemieux added 15 commits October 31, 2025 15:44
@glemieux
manually remove superseded transfer bc calls
ecdde4d
@glemieux
manually remove wraptransfer calls
7a5526d
@glemieux
remove superseded code from the elm fates interface
076013d
@glemieux
add P and N litter fluxes to the fates interface registry
5df0eca
@glemieux
remove all litter flux bc calculations
587de72 
These have moved into fates
@glemieux
correct decomp pool registration calls
ddc5451
@glemieux
add decomp litter poo type variable usage
ca0e605
@glemieux
split up the registration subroutines to accomodate registration that…
83a85af 
… can/should take place during init_coldstart instead of init

This will mostly be the non-global data type variables
@glemieux
correct the site check call to the new fates registry name
8d2d040
@glemieux
remove decomp_id
3338363 
Since we pass vert_soilc namelist tag, we can replace this init_soil_depths logic on the fates side
@glemieux
correct registerinterfacevariablesinit call
243c488
@glemieux
remove duplicate interface variable registration
1e07319
@glemieux
add interface variable initialization update during cold start
e7573ba
@glemieux
temporary diagnostics
a781bbf
@glemieux
add registration calls for restart
b391bcf
@glemieux glemieux force-pushed the lnd/fates-bc-refactor-patch-direct branch from cdb63c5 to b391bcf Compare October 31, 2025 22:44
@glemieux glemieux force-pushed the lnd/fates-bc-refactor-patch-direct branch from dfcf8fd to 4a81700 Compare November 25, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@glemieux