Skip to content

Conversation

@taddyb
Copy link

@taddyb taddyb commented Aug 31, 2025

This PR is meant to integrate all t-route and icefabric changes into the RnR system

Removals

  • removed all icefabric wheels as there were dependency conflicts

Changes

  • moved docs into the docker folder for clarity
  • removed the Dockerfile.post-process as it was a dup

Testing

 tadd.bindas@U-1S6XF6R04GI88  ~/.../Source/docker  NGWPC-7009  ./run_post_process.sh 
Reading the hydrofabric
Opening all forecasts for times after the current timestep
Processing complete! Results saved to: /t-route/data/output/output_inundation_2025-08-31_20:46:25.csv
,feature_id,feature_id_str,strm_order,name,state,streamflow_cfs,inherited_rfc_forecasts,max_status,reference_time,update_time,geom
0,253684,wb-253684,5,Ogeechee River near Eden,GA,3610.0034,action issued 2025-08-31_18:00:00 at EDEG1 (9944828 [order 5]) 0.0 miles upstream,action,2025-08-31_18:00:00,2025-08-31_20:46:25,"MULTILINESTRING ((1362833.569758001 1119754.666514036, 1362842.5709675797 1119696.6065473508, 1362792.0249975533 1119626.74801312, 1362778.294640952 1119583.2622150448, 1362795.3331535608 1119539.3858414406, 1362820.0025701674 1119512.2015823093, 1362850.223985323 1119498.7863169091, 1362901.7668214578 1119496.4368081153, 1362917.3721443415 1119478.1890394667, 1362912.415513838 1119394.7213671866, 1362881.3610333693 1119364.066947123, 1362688.9500395758 1119285.1060791202, 1362679.5910441708 1119262.9739474137, 1362679.5240086762 1119213.8652378218, 1362666.194970789 1119167.8556702044, 1362663.4072864603 1119136.41664092, 1362688.623504436 1119122.226604926, 1362764.357372978 1119128.8134583328, 1362780.515383664 1119123.560940576, 1362793.092228514 1119091.9195959563, 1362750.1625580897 1118906.923960355, 1362739.9564461166 1118840.7207885329, 1362749.5375637398 1118712.991633016, 1362719.8875268323 1118656.7060782798, 1362602.6661233285 1118571.3201763951, 1362569.7373744645 1118519.6937667849, 1362548.5229567925 1118475.0596350494, 1362554.7182655835 1118385.5669994012, 1362582.5449826901 1118338.178982811, 1362648.008844173 1118229.446884621, 1362713.6967619034 1118185.358500588, 1362784.5075445424 1118157.581615279, 1362827.4586938843 1118128.0523380493, 1362840.581674788 1118109.4131097696, 1362889.9788412848 1117972.340507226, 1362900.035262204 1117916.4455251794, 1362908.524235115 1117869.2626365295, 1362948.419753614 1117694.525849584, 1363000.3075340667 1117557.8546397174, 1363025.384065632 1117528.1476484258, 1363062.9531534065 1117500.373216282, 1363242.9371547424 1117411.9704562987, 1363281.5363058518 1117361.1008534087, 1363292.0038048413 1117326.540348184))"
1,253685,wb-253685,5,Ogeechee River near Eden,GA,3610.003,action issued 2025-08-31_18:00:00 at EDEG1 (9944828 [order 5]) 1.9851290944187079 miles upstream,action,2025-08-31_18:00:00,2025-08-31_20:46:25,"MULTILINESTRING ((1363292.0038048413 1117326.540348184, 1363302.3888429096 1117325.5681659617, 1363312.6191833504 1117309.0685026424, 1363350.196161072 1117281.2963609365, 1363398.684247294 1117265.5583206585, 1363446.9288750086 1117267.8803797192, 1363532.6980255055 1117325.1140049489, 1363558.8610347498 1117321.4107710859, 1363557.866433931 1117261.821353083, 1363476.6881321324 1117207.8844059093, 1363324.9719426208 1117080.9681013194, 1363294.9996366515 1117076.3159554007, 1363221.9701709354 1117134.7759055619, 1363198.6973338278 1117136.3258171603, 1363154.1369095694 1117126.838432018, 1363110.197705335 1117096.7635764696, 1363088.9824146095 1117052.1142267396, 1363084.464820241 1117015.2357365172, 1363095.5073120713 1116910.9913651012, 1363175.708233363 1116690.8243529575, 1363194.8550707954 1116649.8700803707, 1363250.574423162 1116307.026089808, 1363290.7330159736 1116246.0526045496, 1363344.5971225584 1116228.5741425669, 1363402.843812583 1116232.4425282248, 1363451.3928528703 1116265.809994612, 1363500.5743683362 1116278.5995490076))"
2

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@taddyb taddyb merged commit 75abbe0 into pi-7-NGWPC-6258 Sep 2, 2025
1 check passed
@taddyb taddyb deleted the NGWPC-7009 branch September 22, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants