NRL-1188 Pass s3 bucket arn as var

Author: jackleary

terraform/infrastructure/firehose.tf

@@ -1,12 +1,12 @@
 module "firehose__processor" {
-  source             = "./modules/firehose"
-  assume_account     = local.aws_account_id
-  prefix             = local.prefix
-  region             = local.region
-  environment        = local.environment
-  cloudwatch_kms_arn = module.kms__cloudwatch.kms_arn
-  splunk_environment = local.splunk_environment
-  splunk_index       = local.splunk_index
-  destination        = "splunk"
-  reporting_bucket   = data.aws_s3_bucket.source-data-bucket
+  source               = "./modules/firehose"
+  assume_account       = local.aws_account_id
+  prefix               = local.prefix
+  region               = local.region
+  environment          = local.environment
+  cloudwatch_kms_arn   = module.kms__cloudwatch.kms_arn
+  splunk_environment   = local.splunk_environment
+  splunk_index         = local.splunk_index
+  destination          = "splunk"
+  reporting_bucket_arn = data.aws_s3_bucket.source-data-bucket.arn
 }

terraform/infrastructure/modules/firehose/kinesis.tf

@@ -63,7 +63,7 @@ resource "aws_kinesis_firehose_delivery_stream" "reporting_stream" {
 
   extended_s3_configuration {
     role_arn   = aws_iam_role.firehose.arn
-    bucket_arn = var.reporting_bucket.arn
+    bucket_arn = var.reporting_bucket_arn
 
     processing_configuration {
       enabled = "true"

terraform/infrastructure/modules/firehose/vars.tf

@@ -35,6 +35,6 @@ variable "error_prefix" {
   default = "errors"
 }
 
-variable "reporting_bucket" {
+variable "reporting_bucket_arn" {
   type = string
 }