Addressed PR comments and fixed some isues that prevented the C5 test from running

Author: Andyg79

pages/datasets/colonoscopy_dataset_page.py

@@ -43,7 +43,7 @@ def select_asa_grade_option(self, option: str) -> None:
         Returns:
         None
         """
-        self.select_asa_grade_dropdowen.select_option(option)
+        self.select_asa_grade_dropdown.select_option(option)
 
     def select_fit_for_colonoscopy_option(self, option: str) -> None:
         """

pages/datasets/subject_datasets_page.py

@@ -11,9 +11,7 @@ def __init__(self, page: Page):
         super().__init__(page)
         self.page = page
         # Subject datasets page locators
-        self.colonoscopy_show_dataset_button = self.page.locator(
-            "body > table > tbody > tr > td > div:nth-child(13) > div.DatasetLink > p > a"
-        )  # Using a more specific selector because we will have multiple buttons on the page with the same role and name
+        self.colonoscopy_show_dataset_button = self.page.get_by_role(role="link", name="Show Dataset")
 
     def click_colonoscopy_show_datasets(self) -> None:
         self.click(self.colonoscopy_show_dataset_button)

pages/screening_practitioner_appointments/appointment_detail_page.py

@@ -10,7 +10,7 @@ def __init__(self, page: Page):
         self.attendance_radio = self.page.get_by_role("radio", name="Attendance")
         self.attendented_check_box = self.page.locator("#UI_ATTENDED")
         self.calendar_button = self.page.get_by_role("button", name="Calendar")
-        self.save_button = self.page.get_by_role("button", name="Save").click()
+        self.save_button = self.page.get_by_role("button", name="Save")
 
     def check_attendance_radio(self) -> None:
         self.attendance_radio.check()

tests/smokescreen/test_compartment_5.py

@@ -76,11 +76,11 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
 
     AppointmentCalendar(page).click_view_appointments_on_this_day_button()
     ScreeningPractitionerDayView(page).click_calendar_button()
-    date_from_util = datetime(2025, 5, 1)
+    date_from_util = datetime(2025, 4, 30)
     CalendarPicker(page).v1_calender_picker(date_from_util)
 
     # Select subject from inital test data util
-    ScreeningPractitionerDayView(page).click_patient_link("CRUMBLE REFUSE")
+    ScreeningPractitionerDayView(page).click_patient_link("HELPER BACKBONED")
 
     # Select Attendance radio button, tick Attended checkbox, set Attended Date to yesterday's (system) date and then press Save
     AppointmentDetail(page).check_attendance_radio()
@@ -93,7 +93,7 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     # Repeat for x Abnormal  patients
 
     # Navigate to the 'Subject Screening Summary' screen for the 1st Abnormal patient
-    nhs_no = "9724560430"  # Test NHS NO for CRUMBLE REFUSE
+    nhs_no = "9840589105"  # Test NHS NO for CRUMBLE REFUSE
     verify_subject_event_status_by_nhs_no(
         page, nhs_no, "J10 - Attended Colonoscopy Assessment Appointment"
     )