Added hardcoded locators to specific POM for test_gfobt_test_kits_page.py

Author: mepr1

pages/base_page.py

@@ -22,7 +22,7 @@ def __init__(self, page: Page):
         self.communications_production_page = self.page.get_by_role("link", name="Communications Production")
         self.download_page = self.page.get_by_role("link", name="Download")
         self.fit_test_kits_page = self.page.get_by_role("link", name="FIT Test Kits")
-        self.gfob_test_kits_page = self.page.get_by_role("link", name="gFOBT Test Kits")
+        self.gfobt_test_kits_page = self.page.get_by_role("link", name="gFOBT Test Kits")
         self.lynch_surveillance_page = self.page.get_by_role("link", name="Lynch Surveillance")
         self.organisations_page = self.page.get_by_role("link", name="Organisations")
         self.reports_page = self.page.get_by_role("link", name="Reports")
@@ -89,8 +89,8 @@ def go_to_download_page(self)->None:
     def go_to_fit_test_kits_page(self)->None:
         self.click(self.fit_test_kits_page)
 
-    def go_to_gfob_test_kits_page(self)->None:
-        self.click(self.gfob_test_kits_page)
+    def go_to_gfobt_test_kits_page(self)->None:
+        self.click(self.gfobt_test_kits_page)
 
     def go_to_lynch_surveillance_page(self)->None:
         self.click(self.lynch_surveillance_page)

pages/gFOBT_create_qc_kit_page.py

@@ -0,0 +1,51 @@
+from playwright.sync_api import Page,expect
+from pages.base_page import BasePage
+from enum import Enum
+
+class CreateQCKit(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+
+        self.create_qc_kit_title = self.page.locator("#ntshPageTitle")
+        # Reading dropdown locators
+        self.reading1dropdown = self.page.locator("#A_C_Reading_999_0_0")
+        self.reading2dropdown = self.page.locator("#A_C_Reading_999_0_1")
+        self.reading3dropdown = self.page.locator("#A_C_Reading_999_1_0")
+        self.reading4dropdown = self.page.locator("#A_C_Reading_999_1_1")
+        self.reading5dropdown = self.page.locator("#A_C_Reading_999_2_0")
+        self.reading6dropdown = self.page.locator("#A_C_Reading_999_2_1")
+        self.save_kit = self.page.get_by_role("button", name="Save Kit")
+        self.kit_has_saved=self.page.locator("th")
+
+    def verify_create_qc_kit_title(self) -> None:
+        expect(self.create_qc_kit_title).to_contain_text("Create QC Kit")
+
+    def go_to_reading1dropdown(self, option: str)-> None:
+        self.reading1dropdown.select_option(option)
+
+    def go_to_reading2dropdown(self, option: str)-> None:
+        self.reading2dropdown.select_option(option)
+
+    def go_to_reading3dropdown(self, option: str)-> None:
+        self.reading3dropdown.select_option(option)
+
+    def go_to_reading4dropdown(self, option: str)-> None:
+        self.reading4dropdown.select_option(option)
+
+    def go_to_reading5dropdown(self, option: str)-> None:
+        self.reading5dropdown.select_option(option)
+
+    def go_to_reading6dropdown(self, option: str)-> None:
+        self.reading6dropdown.select_option(option)
+
+    def go_to_save_kit(self)-> None:
+        self.click(self.save_kit)
+
+    def verify_kit_has_saved(self) -> None:
+        expect(self.kit_has_saved).to_contain_text("A quality control kit has been created with the following values:")
+
+class ReadingDropdownOptions(Enum):
+    NEGATIVE = "NEGATIVE"
+    POSITIVE = "POSITIVE"
+    UNUSED = "UNUSED"

pages/gFOBT_test_kit_logging_page.py

@@ -0,0 +1,11 @@
+from playwright.sync_api import Page,expect
+from pages.base_page import BasePage
+
+class TestKitLogging(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        self.test_kit_logging_title = self.page.locator("#ntshPageTitle")
+
+    def verify_test_kit_logging_title(self) -> None:
+        expect(self.test_kit_logging_title).to_contain_text("Test Kit Logging")

pages/gFOBT_test_kit_quality_control_reading_page.py

@@ -0,0 +1,11 @@
+from playwright.sync_api import Page,expect
+from pages.base_page import BasePage
+
+class TestKitQualityControlReading(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        self.test_kit_quality_control_reading_title = self.page.locator("#ntshPageTitle")
+
+    def verify_test_kit_logging_tile(self) -> None:
+        expect(self.test_kit_quality_control_reading_title ).to_contain_text("Test Kit Quality Control Reading")

pages/gFOBT_test_kits_page.py

@@ -0,0 +1,24 @@
+from playwright.sync_api import Page
+from pages.base_page import BasePage
+
+class GFOBTTestKits(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+
+        self.test_kit_logging_page = self.page.get_by_role("link", name="Test Kit Logging")
+        self.test_kit_reading_page = self.page.get_by_role("link", name="Test Kit Reading")
+        self.test_kit_result_page=self.page.get_by_role("link", name="View Test Kit Result")
+        self.create_qc_kit_page=self.page.get_by_role("link", name="Create QC Kit")
+
+    def go_to_test_kit_logging_page(self)->None:
+        self.click(self.test_kit_logging_page)
+
+    def go_to_test_kit_reading_page(self)->None:
+        self.click(self.test_kit_reading_page)
+
+    def go_to_test_kit_result_page(self)->None:
+        self.click(self.test_kit_reading_page)
+
+    def go_to_create_qc_kit_page(self) -> None:
+        self.click(self.create_qc_kit_page)

pages/gFOBT_view_test_kit_result.py

@@ -0,0 +1,11 @@
+from playwright.sync_api import Page,expect
+from pages.base_page import BasePage
+
+class ViewTestKitResult(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        self.view_test_kit_result_title = self.page.locator("#ntshPageTitle")
+
+    def verify_view_test_kit_result_title(self) -> None:
+        expect(self.view_test_kit_result_title).to_contain_text("View Test Kit Result")

tests/test_contacts_list_page.py

@@ -1,11 +1,9 @@
 import pytest
 from playwright.sync_api import Page, expect
-from pages.base_page import BasePage
+
 from pages.contacts_list_page import ContactsListPage
-from pages.view_contacts_page import ViewContacts
-from pages.edit_my_contact_details_page import EditMyContactDetails
-from pages.maintain_contacts_page import MaintainContacts
-from pages.my_preference_settings_page import MyPreferenceSettings
+from utils.click_helper import click
+from pages.base_page import BasePage
 from utils.user_tools import UserTools
 
 
@@ -28,29 +26,29 @@ def test_contacts_list_page_navigation(page: Page) -> None:
     are loaded when the links are clicked
     """
     # View contacts page loads as expected
-    ContactsListPage(page).go_to_view_contacts_page()
-    ViewContacts(page).verify_view_contacts_title()
-    BasePage(page).click_back_button()
+    click(page, page.get_by_role("link", name="View Contacts"))
+    expect(page.locator("#ntshPageTitle")).to_contain_text("View Contacts")
+    click(page, page.get_by_role("link", name="Back", exact=True))
 
     # Edit my contact details page loads as expected
-    ContactsListPage(page).go_to_edit_my_contact_details_page()
-    EditMyContactDetails(page).verify_edit_my_contact_details_title()
-    BasePage(page).click_back_button()
+    click(page, page.get_by_role("link", name="Edit My Contact Details"))
+    expect(page.locator("#ntshPageTitle")).to_contain_text("Edit My Contact Details")
+    click(page, page.get_by_role("link", name="Back"))
 
     # Maintain contacts page loads as expected
-    ContactsListPage(page).go_to_maintain_contacts_page()
-    MaintainContacts(page).verify_maintain_contacts_title()
-    BasePage(page).click_back_button()
+    click(page, page.get_by_role("link", name="Maintain Contacts"))
+    expect(page.locator("#ntshPageTitle")).to_contain_text("Maintain Contacts")
+    click(page, page.get_by_role("link", name="Back"))
 
     # My preference settings page loads as expected
-    ContactsListPage(page).go_to_my_preference_settings_page()
-    MyPreferenceSettings(page).verify_my_preference_settings_title()
-    BasePage(page).click_back_button()
+    click(page, page.get_by_role("link", name="My Preference Settings"))
+    expect(page.locator("#ntshPageTitle")).to_contain_text("My Preference Settings")
+    click(page, page.get_by_role("link", name="Back"))
 
     # Other links are visible (Not clickable due to user role permissions)
-    ContactsListPage(page).verify_extract_contact_details_page_visible()
-    ContactsListPage(page).verify_resect_and_discard_accredited_page_visible()
+    expect(page.get_by_text("Extract Contact Details")).to_be_visible()
+    expect(page.get_by_text("Resect and Discard Accredited")).to_be_visible()
 
     # Return to main menu
-    BasePage(page).click_main_menu_link()
-    BasePage(page).main_menu_header_is_displayed()
+    click(page, page.get_by_role("link", name="Main Menu"))
+    expect(page.locator("#ntshPageTitle")).to_contain_text("Main Menu")

tests/test_gfobt_test_kits_page.py

@@ -1,78 +1,76 @@
 import pytest
-from playwright.sync_api import Page, expect
-from utils.click_helper import click
+from playwright.sync_api import Page
+
 from pages.base_page import BasePage
+from pages.gFOBT_test_kits_page import GFOBTTestKits
+from pages.gFOBT_test_kit_logging_page import TestKitLogging
+from pages.gFOBT_test_kit_quality_control_reading_page import TestKitQualityControlReading
+from pages.gFOBT_view_test_kit_result import ViewTestKitResult
+from pages.gFOBT_create_qc_kit_page import CreateQCKit, ReadingDropdownOptions
 from utils.user_tools import UserTools
 
 
 @pytest.fixture(scope="function", autouse=True)
 def before_each(page: Page):
     """
     Before every test is executed, this fixture logs in to BCSS as a test user and navigates to the
-    gfob test kits page
+    gfobt test kits page
     """
     # Log in to BCSS
     UserTools.user_login(page, "Hub Manager State Registered")
 
     # Go to gFOBT test kits page
-    BasePage(page).go_to_gfob_test_kits_page()
+    BasePage(page).go_to_gfobt_test_kits_page()
 
 
 @pytest.mark.smoke
-def test_gfob_test_kit_page_navigation(page: Page) -> None:
+def test_gfobt_test_kit_page_navigation(page: Page) -> None:
     """
-    Confirms all menu items are displayed on the gfob test kits page, and that the relevant pages
+    Confirms all menu items are displayed on the gfobt test kits page, and that the relevant pages
     are loaded when the links are clicked
     """
     # Test kit logging page opens as expected
-    click(page, page.get_by_role("link", name="Test Kit Logging"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("Test Kit Logging")
-    click(page, page.get_by_role("link", name="Back"))
+    GFOBTTestKits(page).go_to_test_kit_logging_page()
+    TestKitLogging(page).verify_test_kit_logging_title()
+    BasePage(page).click_back_button()
 
     # Test kit reading page opens as expected
-    click(page, page.get_by_role("link", name="Test Kit Reading"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("Test Kit Quality Control Reading")
-    click(page, page.get_by_role("link", name="Back"))
+    GFOBTTestKits(page).go_to_test_kit_result_page()
+    TestKitQualityControlReading(page).verify_test_kit_logging_tile()
+    BasePage(page).click_back_button()
 
     # View test kit result page opens as expected
-    click(page, page.get_by_role("link", name="View Test Kit Result"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("View Test Kit Result")
-    click(page, page.get_by_role("link", name="Back"))
+    GFOBTTestKits(page).go_to_test_kit_result_page()
+    ViewTestKitResult(page).verify_view_test_kit_result_title()
+    BasePage(page).click_back_button()
 
     # Create qc kit page opens as expected
-    click(page, page.get_by_role("link", name="Create QC Kit"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("Create QC Kit")
+    GFOBTTestKits(page).go_to_create_qc_kit_page()
+    CreateQCKit(page).verify_create_qc_kit_title()
+    BasePage(page).click_back_button()
 
     # Return to main menu
-    click(page, page.get_by_role("link", name="Main Menu"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("Main Menu")
+    BasePage(page).click_main_menu_link()
+    BasePage(page).main_menu_header_is_displayed()
 
 
 def test_create_a_qc_kit(page: Page) -> None:
     """
     Confirms that a qc test kit can be created and that each of the dropdowns has an option set available for selection
     """
-    # 'Reading' dropdown locators
-    reading1dropdown = page.locator("#A_C_Reading_999_0_0")
-    reading2dropdown = page.locator("#A_C_Reading_999_0_1")
-    reading3dropdown = page.locator("#A_C_Reading_999_1_0")
-    reading4dropdown = page.locator("#A_C_Reading_999_1_1")
-    reading5dropdown = page.locator("#A_C_Reading_999_2_0")
-    reading6dropdown = page.locator("#A_C_Reading_999_2_1")
-
     # Navigate to create QC kit page
-    click(page, page.get_by_role("link", name="Create QC Kit"))
+    GFOBTTestKits(page).go_to_create_qc_kit_page()
 
     # Select QC kit drop down options
-    reading1dropdown.select_option("NEGATIVE")
-    reading2dropdown.select_option("POSITIVE")
-    reading3dropdown.select_option("POSITIVE")
-    reading4dropdown.select_option("UNUSED")
-    reading5dropdown.select_option("NEGATIVE")
-    reading6dropdown.select_option("POSITIVE")
+    CreateQCKit(page).go_to_reading1dropdown(ReadingDropdownOptions.NEGATIVE.value)
+    CreateQCKit(page).go_to_reading2dropdown(ReadingDropdownOptions.POSITIVE.value)
+    CreateQCKit(page).go_to_reading3dropdown(ReadingDropdownOptions.POSITIVE.value)
+    CreateQCKit(page).go_to_reading4dropdown(ReadingDropdownOptions.UNUSED.value)
+    CreateQCKit(page).go_to_reading5dropdown(ReadingDropdownOptions.NEGATIVE.value)
+    CreateQCKit(page).go_to_reading6dropdown(ReadingDropdownOptions.POSITIVE.value)
 
     # Click save
-    click(page, page.get_by_role("button", name="Save Kit"))
+    CreateQCKit(page).go_to_save_kit()
 
     # Verify kit has saved
-    expect(page.locator("th")).to_contain_text("A quality control kit has been created with the following values:")
+    CreateQCKit(page).verify_kit_has_saved()