Skip to content

Feature/bcss 20261 fix failing tests#25

Merged
Andyg79 merged 18 commits intomainfrom
feature/BCSS-20261-fix-failing-tests
Apr 24, 2025
Merged

Feature/bcss 20261 fix failing tests#25
Andyg79 merged 18 commits intomainfrom
feature/BCSS-20261-fix-failing-tests

Conversation

@Andyg79
Copy link

@Andyg79 Andyg79 commented Apr 24, 2025

Description

This story covers fixing any failing Playwright tests

Context

We have done some refactoring recently and added some functions/utils and some of our tests were failing. This story covers identifying and fixing any failing tests.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes (where appropriate)
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Andyg79 and others added 17 commits April 17, 2025 10:49
test_operational_reports_screening_practitioner_6_weeks_availability_not_set_up
test_operational_reports_screening_practitioner_appointments
Fixed failing test:

test_operational_reports_screening_practitioner_appointments
Removed pytest mark that was committed by mistake
…_main_menu_link()

Possibily conflicting with the click method waits?
…ed out/not visible to playwright, on log in.

Removed this step and test is now passing.
@Andyg79 Andyg79 requested a review from davethepunkyone April 24, 2025 09:47
@davethepunkyone davethepunkyone added the bug Something isn't working label Apr 24, 2025
@sonarqubecloud
Copy link

@Andyg79 Andyg79 merged commit ec77a67 into main Apr 24, 2025
14 checks passed
@Andyg79 Andyg79 deleted the feature/BCSS-20261-fix-failing-tests branch April 24, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments