Skip to content

Comments

https://nhsd-jira.digital.nhs.uk/browse/BCSS-20365 - BCSS - Playwrig…#42

Merged
vidhya-chandra1 merged 13 commits intomainfrom
feature/BCSS-20365-compartment-5-pom-for-contact-with-patient-page
May 2, 2025
Merged

https://nhsd-jira.digital.nhs.uk/browse/BCSS-20365 - BCSS - Playwrig…#42
vidhya-chandra1 merged 13 commits intomainfrom
feature/BCSS-20365-compartment-5-pom-for-contact-with-patient-page

Conversation

@vidhya-chandra1
Copy link

Compartment 5- POM for 'Contact with Patient' page

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes (where appropriate)
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

…t - Compartment 5- POM for 'Contact with Patient' page
@vidhya-chandra1 vidhya-chandra1 added the enhancement New feature or request label Apr 30, 2025
@davethepunkyone
Copy link
Collaborator

Hi @vidhya-chandra1 - is this one actually ready for review? You've flagged it for us but Sonar's highlighting a lot of duplication and it doesn't look like the class being renamed has transferred over into your pull request

@vidhya-chandra1
Copy link
Author

Hi @vidhya-chandra1 - is this one actually ready for review? You've flagged it for us but Sonar's highlighting a lot of duplication and it doesn't look like the class being renamed has transferred over into your pull request

Hi Dave, As you said previosuly the code changes pushed was not reflected. Currently the issue is Fixed & now Latest changes are pushed to PR. Kindly review it. Thanks!

@Andyg79
Copy link

Andyg79 commented May 1, 2025

Hi Vidhya, it looks like you have merge conflicts that need resolving on test_compartment_5. Let me know if you want to go through them together.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2025

@vidhya-chandra1 vidhya-chandra1 merged commit ffae33e into main May 2, 2025
10 checks passed
@vidhya-chandra1 vidhya-chandra1 deleted the feature/BCSS-20365-compartment-5-pom-for-contact-with-patient-page branch May 2, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants