Skip to content

Comments

Feature/bcss 20443 compartment 6 pom record diagnosis date#63

Merged
adrianoaru-nhs merged 6 commits intomainfrom
feature/BCSS-20443-compartment-6-pom-record-diagnosis-date
May 13, 2025
Merged

Feature/bcss 20443 compartment 6 pom record diagnosis date#63
adrianoaru-nhs merged 6 commits intomainfrom
feature/BCSS-20443-compartment-6-pom-record-diagnosis-date

Conversation

@adrianoaru-nhs
Copy link

Description

New POM for the record diagnosis date page

Context

Allowing for the locators in this page to be reused

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes (where appropriate)
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@adrianoaru-nhs adrianoaru-nhs requested a review from a team May 13, 2025 14:02
@adrianoaru-nhs adrianoaru-nhs self-assigned this May 13, 2025
@adrianoaru-nhs adrianoaru-nhs added the enhancement New feature or request label May 13, 2025
@sonarqubecloud
Copy link

@adrianoaru-nhs adrianoaru-nhs merged commit 6742386 into main May 13, 2025
10 checks passed
@adrianoaru-nhs adrianoaru-nhs deleted the feature/BCSS-20443-compartment-6-pom-record-diagnosis-date branch May 13, 2025 15:11
victor-soares-ibm pushed a commit that referenced this pull request May 13, 2025
<!-- markdownlint-disable-next-line first-line-heading -->
## Description

<!-- Describe your changes in detail. -->
New POM for the record diagnosis date page

## Context

<!-- Why is this change required? What problem does it solve? -->
Allowing for the locators in this page to be reused

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [ ] I have added tests to cover my changes (where appropriate)
- [x] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants