BCSS – Playwright - Load Properties Markdown Improvements#89
Merged
vidhya-chandra1 merged 15 commits intomainfrom May 29, 2025
Merged
Conversation
… - BCSS – Playwright - Load Properties Markdown Improvements, Implemented the Code Refactoring.
vidhya-chandra1
added
documentation
adrianoaru-nhs
requested changes
May 28, 2025
… on storing some values in the properties file.
…into feature/BCSS-20628-load-properties-markdown-improvements
…s' of https://github.com/NHSDigital/bcss-playwright into feature/BCSS-20628-load-properties-markdown-improvements
…the properties file.
…into feature/BCSS-20628-load-properties-markdown-improvements
…into feature/BCSS-20628-load-properties-markdown-improvements
…s' of https://github.com/NHSDigital/bcss-playwright into feature/BCSS-20628-load-properties-markdown-improvements
…s' of https://github.com/NHSDigital/bcss-playwright into feature/BCSS-20628-load-properties-markdown-improvements
adrianoaru-nhs
requested changes
May 29, 2025
|
adrianoaru-nhs
approved these changes
May 29, 2025
vidhya-chandra1
deleted the
feature/BCSS-20628-load-properties-markdown-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BCSS – Playwright - Load Properties Markdown Improvements, Implemented the Code Refactoring.
Description
"Example Usage" with Python code block is added to the top level summary explaining that the properties files use key value pairs and the reason for using it is to avoid hard coded values in our tests.
Type of changes
Example Usage with Python code block is added to the Top Level Summary.
Total File Updated - 1 (Name - LoadProperties.md)
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.