fix: fix the sort order params #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes the sort order parameters by correcting the mapping between sort option values and their corresponding sort behaviors across the exception handling system.
- Swapped the sort option values so "0" represents oldest first (ascending) and "1" represents newest first (descending)
- Updated the sort logic in the API route to match the corrected value mappings
- Updated test expectations to reflect the new sort order behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| application/CohortManager/src/Web/app/exceptions/page.tsx | Updated sort option values and default sort logic for general exceptions page |
| application/CohortManager/src/Web/app/exceptions/[filter]/page.tsx | Updated sort option values and default sort logic for filtered exceptions page |
| application/CohortManager/src/Web/app/api/GetValidationExceptions/route.ts | Fixed sort logic to match corrected value mappings with added comments |
| application/CohortManager/src/Web/tests/features/raisedExceptions.feature | Updated expected exception IDs in test scenarios |
| application/CohortManager/src/Web/tests/features/notRaisedExceptions.feature | Updated expected exception IDs in test scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Rabo2024
approved these changes
Sep 16, 2025
Unit Test Results✔️ Tests 843 / 843 - passed in 60.8s |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the sort order parameters by correcting the mapping between sort option values and their corresponding sort behaviors across the exception handling system.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.