Skip to content

Conversation

@Warren-Pitterson
Copy link
Contributor

@Warren-Pitterson Warren-Pitterson commented Oct 29, 2025

Description

  • Added Pagination to Reports details page
  • Removed fetchReports.ts` - all API calls now use fetchExceptions
  • Moved pagination logic into Pagination component to eliminate duplication
  • Added dynamic pageSize & added pageSize defaulting to 10 in PaginationService
  • Reports show all records on 1 page

Context

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11460

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Unit Test Results

✔️ Tests 855 / 855 - passed in 65.1s
📝 Coverage 57.02%
📏 4511 / 7776 lines covered 🌿 1085 / 2038 branches covered
🔍 click here for more details

✏️ updated for commit 7465e6d

@Warren-Pitterson Warren-Pitterson marked this pull request as ready for review October 29, 2025 19:22
@sonarqubecloud
Copy link

@Warren-Pitterson Warren-Pitterson added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit d6f59b1 Oct 30, 2025
68 checks passed
@Warren-Pitterson Warren-Pitterson deleted the feat/DTOSS-11460-reports-page-update branch October 30, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants