fix: RetrieveCohortDistribution API updated to check if a superseded by nhs number has existing record #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
application/CohortManager/src/Functions/Shared/Data/Database/CreateCohortDistributionData.cs
Outdated
Show resolved
Hide resolved
...ication/CohortManager/src/Functions/Shared/Data/Database/ExtractCohortDistributionRecords.cs
Outdated
Show resolved
Hide resolved
...ication/CohortManager/src/Functions/Shared/Data/Database/ExtractCohortDistributionRecords.cs
Outdated
Show resolved
Hide resolved
Warren-Pitterson
previously approved these changes
Dec 3, 2025
Warren-Pitterson
approved these changes
Dec 3, 2025
|
SamAinsworth-NHS
approved these changes
Dec 4, 2025
stephhou
added
the
Deployment 1.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11459
When a call is made to the RetrieveBSCohortDistribution API it will try to retrieve and return records that do not have a superseded by number.
If there are no records to return without a superseded by number, it retrieves records with a superseded by number. For each record it checks if an entry exists where the superseded by number is the NHS number, if an entry exists the record is added the batch to be returned via API.
Context
This change is required because currently Cohort Manager sends records to BS Select in the order they are processed. Cohort Manager can process a record with a superseded by NHS number before a record has been created with the details of the superseded by NHS Number as the NHS Numbver This causes an error in the BS Select system as they are unable to handle the supersession without the new record to transfer history to.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.