Skip to content

Conversation

@Warren-Pitterson
Copy link
Contributor

@Warren-Pitterson Warren-Pitterson commented Dec 2, 2025

Description

  • NHS number search with dedicated results page
  • "No Results" error page with inline search
  • Report details page filters by NHS number

Context

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11236

Both exceptions and reports No Results Invalid No Results Valid Same NHS Confusion results Same Superseded NHS Number Search bar in header

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Unit Test Results

✔️ Tests 891 / 891 - passed in 66.4s
📝 Coverage 46.8%
📏 4585 / 10077 lines covered 🌿 1124 / 2122 branches covered
🔍 click here for more details

✏️ updated for commit 912b4da

@Warren-Pitterson Warren-Pitterson marked this pull request as ready for review December 2, 2025 17:00
chrimesdev
chrimesdev previously approved these changes Dec 11, 2025
MWClayson-NHS
MWClayson-NHS previously approved these changes Dec 11, 2025
@sonarqubecloud
Copy link

@rfk-nc rfk-nc added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 0bfee35 Dec 12, 2025
68 checks passed
@rfk-nc rfk-nc deleted the feat/DTOSS-10947-UI-Search branch December 12, 2025 14:41
@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants