Skip to content

Conversation

@stephhou
Copy link
Contributor

@stephhou stephhou commented Dec 3, 2025

Description

Ticket: https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11714

  • Edited existing superseded rule 60 to only transform the reason for removal to ORR when the record does not have an existing Reason for Removal.
  • Added superseded rule 61 which is a no transform rule but is required to raise an exception for all superseded records that do have an existing RfR so they are included in the superseded UI report.
  • Added the superseded category 13 to rule 61 to ensure reporting is possible.

Context

Currently the reason for removal on superseded records is transformed to ORR. This rule was originally introduced to ensure that all superseded records were deducted in BS Select. From observing the rule and the output it was agreed that it was important to understand the context of the original RfR (if there is one) to understand the best cause of action for that record.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Unit Test Results

✔️ Tests 895 / 895 - passed in 71.6s
📝 Coverage 47.01%
📏 4630 / 10127 lines covered 🌿 1136 / 2138 branches covered
🔍 click here for more details

✏️ updated for commit 56ad4d6

@stephhou stephhou changed the title DTOSS-11714 DTOSS-11714 Updating rule 60 Superseded Numbers and adding a new rule 61 Dec 3, 2025
@stephhou stephhou changed the title DTOSS-11714 Updating rule 60 Superseded Numbers and adding a new rule 61 fix: DTOSS-11714 Updating rule 60 Superseded Numbers and adding a new rule 61 Dec 3, 2025
@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 12, 2025
@stephhou stephhou marked this pull request as ready for review December 14, 2025 21:07
@sonarqubecloud
Copy link

@stephhou stephhou added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit f85e143 Dec 15, 2025
67 checks passed
@stephhou stephhou deleted the fix/DTOSS-11714-Edit-Rule-60-supersedes branch December 15, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants