Skip to content

Conversation

@MWClayson-NHS
Copy link
Contributor

@MWClayson-NHS MWClayson-NHS commented Dec 5, 2025

Description

  • Update rule 45 according to DTOSS-11715
  • Remove unused global param from Lookup Rules
  • Update Unit tests, Now covers all scenarios.
  • Refactor Negative tests for Rule 45 so they align to the same structure as the positive tests
  • E2E test added to cover HMP Scenario

Context

DTOSS-11715

CYM Current Posting needs to flow to be deducted by transformation rule 8. Excluded DMS will not hit this rule due to the conditionality within this rule to allow them to flow to transformation rule 8 already. 

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Unit Test Results

✔️ Tests 903 / 903 - passed in 66.6s
📝 Coverage 47.01%
📏 4630 / 10127 lines covered 🌿 1136 / 2138 branches covered
🔍 click here for more details

✏️ updated for commit f3cb92b

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Your Pull Request title must meet the conventional commit standards, please see the following documentation - https://www.conventionalcommits.org/en/v1.0.0/#specification

@MWClayson-NHS MWClayson-NHS changed the title Feat/bss rule fixes fix: BSS rule fixes Dec 5, 2025
@MWClayson-NHS MWClayson-NHS marked this pull request as ready for review December 8, 2025 11:12
Copy link
Contributor

@stephhou stephhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added 3 comments

@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 12, 2025
stephhou
stephhou previously approved these changes Dec 15, 2025
@rfk-nc rfk-nc changed the title fix: BSS rule fixes fix: DTOSS-11715 BSS rule fixes Dec 15, 2025
@sonarqubecloud
Copy link

@MWClayson-NHS MWClayson-NHS added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 05923c6 Dec 17, 2025
67 checks passed
@MWClayson-NHS MWClayson-NHS deleted the feat/BSS-Rule-Fixes branch December 17, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants