Skip to content

Conversation

@stephhou
Copy link
Contributor

@stephhou stephhou commented Dec 16, 2025

Description

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11868
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11878

  • Changed the rule number of 17.AddressLinesNullAndPostcodeDoesNotMatchExisting.NBO.NonFatal to 71 so that it matches the mapping in the rules mapping file.
  • Removed 4 rule mapping descriptions that are not used.
    • Rule 10 is now a transformation rule
    • Rule 21 is now rules 60 and 61 - superseded
    • Rule 22 no longer exists
    • Rule 69 - we don't receive records with invalid set to true, they come through as DEL's

Context

A bug was raised concerning duplicate exceptions. Discovered that rule 17 for address changes was mapping to the date of birth rule description therefore the NSD and NBO were receiving the incorrect error message.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@stephhou stephhou marked this pull request as draft December 16, 2025 17:14
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Unit Test Results

✔️ Tests 895 / 895 - passed in 67.8s
📝 Coverage 47.01%
📏 4630 / 10127 lines covered 🌿 1136 / 2138 branches covered
🔍 click here for more details

✏️ updated for commit 6b5ccd8

@sonarqubecloud
Copy link

@stephhou stephhou marked this pull request as ready for review December 16, 2025 17:52
@stephhou stephhou added the Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025 label Dec 17, 2025
@stephhou
Copy link
Contributor Author

Discussed with Delivery Lead and Assurance and this has been agreed to be added to release 1.0.4

@stephhou stephhou added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 3632462 Dec 17, 2025
68 checks passed
@stephhou stephhou deleted the fix/DTOSS-11868-incorrect-rule-numbers branch December 17, 2025 09:59
@stephhou stephhou changed the title fix: DTOSS-11868 updated rule numbers fix: DTOSS-11878 updated rule numbers Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deployment 1.0.4 All PRs assigned for deployment 1.0.4 - planned for 18/12/2025

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants