generated from nhs-england-tools/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: central package management #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MWClayson-NHS
wants to merge
70
commits into
main
Choose a base branch
from
feat/central-package-management
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
8baa8d2
partial commit
MWClayson-NHS 92564d7
Partially working
MWClayson-NHS 6bfe87b
base docker image part 1
MWClayson-NHS a699339
fix build issues
MWClayson-NHS db5227b
fix broken test
MWClayson-NHS c62d6dd
function base image
MWClayson-NHS aa05cb0
testing docker base image on function
MWClayson-NHS e63a0fd
updating docker files
MWClayson-NHS d36108f
update build to also build base images
MWClayson-NHS aab5653
update build bug
MWClayson-NHS 30bf756
commit testing build
MWClayson-NHS 68b4503
fixing env varible
MWClayson-NHS 5bec52c
fix build issue
MWClayson-NHS 0b93a77
test
MWClayson-NHS cf2fa2f
test list all images
MWClayson-NHS 8137c6b
testing changes
MWClayson-NHS 524cc63
typo
MWClayson-NHS 2871e5c
test
MWClayson-NHS 04419a7
typo
MWClayson-NHS d8ad709
more testing
MWClayson-NHS 3796f3a
test login action
MWClayson-NHS 3a1fe6c
add checkout step
MWClayson-NHS 94e19d0
update permissions
MWClayson-NHS 733dafc
Detect base image changes
MWClayson-NHS 68bc249
changing base image build check script
MWClayson-NHS 42b2879
fix perms
MWClayson-NHS 89955c5
checking run
MWClayson-NHS e306de0
fix following slash bug
MWClayson-NHS fbe6356
set image tags step
MWClayson-NHS 501a2d9
fixing shell bugs
MWClayson-NHS 8858991
remove wild card from change detector
MWClayson-NHS a3e8079
refactor image tag logic
MWClayson-NHS 27bdfe3
trim white space
MWClayson-NHS 1305340
bug fix
MWClayson-NHS 13e483f
fix space removal bug
MWClayson-NHS 768078b
test build
MWClayson-NHS fe8e542
bug in building base image
MWClayson-NHS 98dab4c
test pushing to ghcr
MWClayson-NHS 7e9e2dc
test full build.
MWClayson-NHS a18efba
correct output issues
MWClayson-NHS 15e7d2d
test build change
MWClayson-NHS a2512bb
testing more fixes?
MWClayson-NHS 97ce599
moving base image names to step env varibles
MWClayson-NHS 83805a7
extra logging and activities
MWClayson-NHS 97d873b
removing docker images step
MWClayson-NHS 13c612b
testing with a .env file in pipeline
MWClayson-NHS 2708010
hard coding to test
MWClayson-NHS c1c6a0a
remove spaces from export
MWClayson-NHS e249a1e
testing more env sending
MWClayson-NHS e1b65a5
fix quote marks
MWClayson-NHS 711403c
more testing of build process
MWClayson-NHS 56b0d27
update base image
MWClayson-NHS 2ccea55
use env file
MWClayson-NHS 3fff031
use correct pipeline
MWClayson-NHS afdc9c7
update all functions to use base image
MWClayson-NHS 9e8938f
correct docker files
MWClayson-NHS 279ea87
incorrect path
MWClayson-NHS 1d2a0e5
incorrect work dir
MWClayson-NHS 0e3bf60
Tidy Build Images
MWClayson-NHS f0d64f2
add push to main logic
MWClayson-NHS a7d3a9d
revert change to speed up cicd
MWClayson-NHS 48cf466
Merge branch 'main' into feat/central-package-management
MWClayson-NHS 5db4f74
update dotnet mesh client
MWClayson-NHS 9224d56
Merge branch 'main' into feat/central-package-management
MWClayson-NHS 5d41eae
Merge branch 'main' into feat/central-package-management
MWClayson-NHS 38100e2
fix tagging
MWClayson-NHS 6a0a1a0
typo
MWClayson-NHS b5f90c9
update build base image to always run on main
MWClayson-NHS 8e16011
Merge branch 'main' into feat/central-package-management
MWClayson-NHS 6a01fe7
Missing package ref
MWClayson-NHS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <Project> | ||
| <PropertyGroup Condition="'$(MSBuildProjectName)' == 'WorkerExtensions'"> | ||
| <ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
| <TreatWarningsAsErrors>false</TreatWarningsAsErrors> | ||
| <NoWarn>$(NoWarn);NU1605;NU1701;NU1507</NoWarn> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <Project> | ||
| <PropertyGroup Condition=" | ||
| '$(UsingMicrosoftNETSdkWorker)' == 'true' | ||
| and '$(IsTestProject)' == 'true' | ||
| "> | ||
| <FunctionsGenerateWorkerExtensions>false</FunctionsGenerateWorkerExtensions> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <!-- Enable central package management, | ||
| https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management --> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageVersion Include="Azure.Messaging.ServiceBus" Version="7.20.1" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker" Version="2.0.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Http" Version="3.3.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Storage.Blobs" | ||
| Version="6.7.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Sdk" Version="2.0.4" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.ApplicationInsights" Version="2.0.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="9.0.2" /> | ||
| <PackageVersion Include="Polly" Version="8.5.0" /> | ||
| <PackageVersion Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.4.0" /> | ||
| <PackageVersion Include="Azure.Identity" Version="1.14.1" /> | ||
| <PackageVersion Include="Azure.Security.KeyVault.Certificates" Version="4.6.0" /> | ||
| <PackageVersion Include="Azure.Security.KeyVault.Secrets" Version="4.6.0" /> | ||
| <PackageVersion Include="Azure.Storage.Blobs" Version="12.20.0" /> | ||
| <PackageVersion Include="Azure.Storage.Queues" Version="12.20.1" /> | ||
| <PackageVersion Include="Azure.Messaging.EventGrid" Version="4.28.0" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights.DependencyCollector" Version="2.23.0" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights.WorkerService" Version="2.23.0" /> | ||
| <PackageVersion Include="Microsoft.AspNetCore.WebUtilities" Version="8.0.7" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Azure" Version="1.12.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Options.DataAnnotations" Version="9.0.6" /> | ||
| <PackageVersion Include="Microsoft.Identity.Client" Version="4.74.0" /> | ||
| <PackageVersion Include="Microsoft.IdentityModel.Tokens" Version="8.12.1" /> | ||
| <PackageVersion Include="Hl7.Fhir.R4" Version="5.11.4" /> | ||
| <PackageVersion Include="System.IdentityModel.Tokens.Jwt" Version="8.12.1" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.6" /> | ||
| <PackageVersion Include="System.Linq.Dynamic.Core" Version="1.7.1" /> | ||
| <PackageVersion Include="ParquetSharp" Version="17.0.0-beta1" /> | ||
| <PackageVersion Include="RulesEngine" Version="5.0.5" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.Tools" Version="10.0.1" /> | ||
| <PackageVersion Include="Microsoft.Extensions.HealthChecks.AzureStorage" Version="1.0.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.6" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="9.0.3" /> | ||
| <PackageVersion Include="System.Runtime.Caching" Version="8.0.1" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore" | ||
| Version="2.0.2" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Timer" Version="4.3.1" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.DurableTask" | ||
| Version="1.4.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.ServiceBus" | ||
| Version="5.23.0" /> | ||
| <PackageVersion Include="Grpc.Net.Client" Version="2.70.0" /> | ||
| <PackageVersion Include="Contrib.Grpc.Core.M1" Version="2.41.0" /> | ||
| <PackageVersion Include="Hl7.Fhir.STU3" Version="4.3.0" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore" Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite" | ||
| Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.8" /> | ||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" /> | ||
| <PackageVersion Include="Moq" Version="4.20.72" /> | ||
| <PackageVersion Include="MSTest" Version="3.6.4" /> | ||
| <PackageVersion Include="MSTest.TestAdapter" Version="3.1.1" /> | ||
| <PackageVersion Include="MSTest.TestFramework" Version="3.1.1" /> | ||
| <PackageVersion Include="coverlet.collector" Version="6.0.0" /> | ||
| <PackageVersion Include="FluentAssertions" Version="6.12.2" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.3" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.1" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| FROM mcr.microsoft.com/dotnet/sdk:8.0 AS base | ||
|
|
||
| COPY Directory.Build.props /app/Directory.Build.props | ||
| COPY Directory.Build.targets /app/Directory.Build.targets | ||
| COPY Directory.Packages.props /app/Directory.Packages.props | ||
|
|
||
| COPY ./application/CohortManager/src/Functions/Shared/ /app/Shared | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| FROM mcr.microsoft.com/dotnet/sdk:8.0 AS base | ||
|
|
||
| # Copy Build and Package Properties | ||
| COPY Directory.Build.props /app/Directory.Build.props | ||
| COPY Directory.Build.targets /app/Directory.Build.targets | ||
| COPY Directory.Packages.props /app/Directory.Packages.props | ||
|
|
||
|
|
||
| COPY ./application/CohortManager/src/Functions/Shared/ /app/Shared | ||
|
|
||
| WORKDIR /app/Shared | ||
|
|
||
| RUN mkdir -p /home/site/wwwroot && \ | ||
| dotnet publish ./Common/Common.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./Model/Model.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./Data/Data.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./Utilities/Utilities.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./DataServices.Client/DataServices.Client.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./DataServices.Core/DataServices.Core.csproj --output /home/site/wwwroot && \ | ||
| dotnet publish ./DataServices.Database/DataServices.Database.csproj --output /home/site/wwwroot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 4 additions & 17 deletions
21
application/CohortManager/src/Functions/CaasIntegration/receiveCaasFile/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.