fix: DTOSS-8428 letsencrypt certificate module supports multiple DNS domains #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change, one of several required in order to publish the Participant Manager and Cohort Manager frontend Azure Web Apps, has proved complex since the SSL certificates exist as entities within the App Service Plan which is a separate Terraform module from the Azure Web App module. The certificate being loaded on also originates in a different Terraform state and Azure subscription (the DTOS Hub). The custom domain binding requires a DNS challenge TXT record to be created - also in the Hub subscription, but this must be done across subscriptions within a child module. Furthermore, the certificates module and the Application Gateway module have required significant changes in order to support a gradual migration from
nationalscreening.nhs.uktoscreening.nhs.uk.Linked to:
Testing
https://dev.azure.com/nhse-dtos/dtos-participant-manager/_build/results?buildId=17564&view=results
https://dev.azure.com/nhse-dtos/dtos-hub/_build/results?buildId=17591&view=results
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.