Skip to content

Conversation

@patrickmoore-nc
Copy link
Contributor

@patrickmoore-nc patrickmoore-nc commented Apr 25, 2025

Description

  1. Adds name and resource_group_name outputs to Application Insights module.
  2. Adds optional Entra ID group memberships for App Services (Function App, Web App).

Neither of these changes is impactful to existing code with module dependencies.

Context

  1. Will allow direct resource references between App Services in tf-core Terraform state, and Application Insights intf-audit Terraform state. Allows the removal of some parameterisation from tfvars for stronger coupling.
  2. Will allow replacement of individual RBAC roles per App Service with RBAC roles assigned via group memberships. Will greatly reduce Terraform deployment times for Cohort Manager (many Function Apps), but will need admin rights over an Organization Unit within Entra ID which is a request pending with CCOE team.

Testing:

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@patrickmoore-nc patrickmoore-nc marked this pull request as ready for review April 25, 2025 11:50
@patrickmoore-nc patrickmoore-nc force-pushed the fix/app-insights-outputs2 branch 2 times, most recently from 270e909 to 5844146 Compare April 25, 2025 12:34
@patrickmoore-nc patrickmoore-nc changed the title Fix: Add outputs to Application Insights module Fix: Add outputs to Application Insights module, Entra ID group memberships for App Services Apr 25, 2025
@patrickmoore-nc patrickmoore-nc force-pushed the fix/app-insights-outputs2 branch 3 times, most recently from 87a0d7d to b30e807 Compare April 25, 2025 12:56
@patrickmoore-nc patrickmoore-nc force-pushed the fix/app-insights-outputs2 branch from b30e807 to 563462f Compare April 25, 2025 13:05
@patrickmoore-nc patrickmoore-nc changed the title Fix: Add outputs to Application Insights module, Entra ID group memberships for App Services Fix: Add outputs to Application Insights module, optional Entra ID group memberships for App Services Apr 25, 2025
@patrickmoore-nc patrickmoore-nc added this pull request to the merge queue Apr 25, 2025
Merged via the queue into main with commit aa2910e Apr 25, 2025
23 checks passed
@patrickmoore-nc patrickmoore-nc deleted the fix/app-insights-outputs2 branch April 25, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants