fix: Rename enable_auth -> enable_entra_id_authentication #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
reviewed
Oct 10, 2025
saliceti
reviewed
Oct 10, 2025
saliceti
reviewed
Oct 10, 2025
saliceti
reviewed
Oct 10, 2025
josielsouzanordcloud
force-pushed
the
fix/update-variable-naming
branch
from
7a2b13b to
42aabca
Compare
Make this variable name clearer as enable_auth=false looks scary and this authentication is just to prevent random web access to the container app. - Ensure documentation and code are up to date and consistent - Regenerate tfdocs.md with latest terraform-docs output
josielsouzanordcloud
force-pushed
the
fix/update-variable-naming
branch
from
ec303a8 to
0e7e540
Compare
saliceti
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make this variable name clearer as enable_auth=false looks scary and this authentication is just to prevent random web access to the container app.
This was updated in NHSDigital/dtos-manage-breast-screening#528 (and NHSDigital/dtos-manage-breast-screening#495 🤦 ) but needed updating here too.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.