Skip to content

Conversation

@mrlockstar
Copy link
Contributor

@mrlockstar mrlockstar commented Oct 24, 2025

Description

The application insights standard web test existed and was working correctly with one major issue; it was not firing an alert. This PR simply adds the alert into the child module.

Evidence it works is below:-

Screenshot 2025-10-24 at 14 31 48 Screenshot 2025-10-24 at 14 33 11

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the fix/DTOSS-00000-add-alerting-to-the-app-insights-availablity-test branch 3 times, most recently from dfc563a to 5decee0 Compare October 24, 2025 14:19
@mrlockstar mrlockstar requested a review from saliceti October 24, 2025 14:19
@mrlockstar mrlockstar force-pushed the fix/DTOSS-00000-add-alerting-to-the-app-insights-availablity-test branch 2 times, most recently from 78297ca to 64b89ae Compare October 24, 2025 14:25
The application insights web availability test was firing but it was not
firing the alert to the email group because the azurerm_monitor_metric_alert
resource was missing. This simply adds this alert into the child module.
@mrlockstar mrlockstar force-pushed the fix/DTOSS-00000-add-alerting-to-the-app-insights-availablity-test branch from 64b89ae to 1513a12 Compare October 24, 2025 14:32
@mrlockstar mrlockstar added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit e678810 Oct 24, 2025
11 checks passed
@mrlockstar mrlockstar deleted the fix/DTOSS-00000-add-alerting-to-the-app-insights-availablity-test branch October 24, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants