Skip to content

Conversation

@patrickmoore-nc
Copy link
Contributor

@patrickmoore-nc patrickmoore-nc commented May 9, 2025

Description

Simplify outputs from LetsEncrypt Certificates module.

Linked to:

Context

We don't really need the full details of the pfx blob as its own object (id, location, name, naming_key, subject, versionless_id). This is because when we are consuming this pfx, we need to access the Key Vault Secret resource's value property, and to do that we need to bind it using a data query. For that we only need to know the secret name, and which Key Vault contains it. Consequently we might as well just add pfx_blob_key_vault_secret_name as another property to the existing main output object. None of the other pfx_blob properties were needed.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@patrickmoore-nc patrickmoore-nc marked this pull request as draft May 9, 2025 18:42
@patrickmoore-nc patrickmoore-nc changed the title fix: simplify letsencrypt-certificates output fix: Simplify letsencrypt-certificates output May 10, 2025
@patrickmoore-nc patrickmoore-nc force-pushed the fix/simplify-letsencrypt-outputs branch from 02b6269 to 035292d Compare May 12, 2025 09:32
Copy link
Contributor

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@patrickmoore-nc patrickmoore-nc marked this pull request as ready for review May 12, 2025 09:35
@patrickmoore-nc patrickmoore-nc added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 30b03e2 May 12, 2025
23 checks passed
@patrickmoore-nc patrickmoore-nc deleted the fix/simplify-letsencrypt-outputs branch May 12, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants