fix: Simplify letsencrypt-certificates output #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify outputs from LetsEncrypt Certificates module.
https://dev.azure.com/nhse-dtos/dtos-hub/_build/results?buildId=18100&view=results
https://dev.azure.com/nhse-dtos/dtos-hub/_build/results?buildId=18101&view=results
Linked to:
Context
We don't really need the full details of the pfx blob as its own object (
id,location,name,naming_key,subject,versionless_id). This is because when we are consuming this pfx, we need to access the Key Vault Secret resource'svalueproperty, and to do that we need to bind it using a data query. For that we only need to know the secret name, and which Key Vault contains it. Consequently we might as well just addpfx_blob_key_vault_secret_nameas another property to the existing main output object. None of the other pfx_blob properties were needed.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.