Skip to content

Conversation

@saliceti
Copy link
Contributor

@saliceti saliceti commented May 12, 2025

Description

Create the private DNS zone for container apps internal domains. Add the zone name and enable it in the development environment for now.

Context

Use internal container apps. Required to enable web apps from NHSDigital/dtos-devops-templates#149.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@saliceti saliceti marked this pull request as draft May 12, 2025 11:24
@saliceti saliceti marked this pull request as ready for review May 12, 2025 13:05
@saliceti saliceti force-pushed the DTOSS-8324-container-apps-private-dns branch from 0e8bdab to 014290e Compare May 12, 2025 13:06
@saliceti saliceti added this pull request to the merge queue May 12, 2025
Merged via the queue into main with commit 3666335 May 12, 2025
23 checks passed
@saliceti saliceti deleted the DTOSS-8324-container-apps-private-dns branch May 12, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants