Merge pull request #746 from NHSDigital/guard-against-blank-prNumber

Guard against blank PR number being passed to test

Author: steventux

scripts/python/smoke_test/notifications_smoke_test.py

@@ -52,10 +52,10 @@ def test_notifications():
 
 def configure():
     environment = os.getenv("ENVIRONMENT", "dev")
-    pr_number = os.getenv("PR_NUMBER")
+    pr_number = os.getenv("PR_NUMBER", "")
     storage_account = f"stmanbrs{environment}uks"
 
-    if pr_number is not None:
+    if pr_number != "":
         environment = f"pr-{pr_number}"
         storage_account = f"stmanbrspr{pr_number}uks"