generated from NHSDigital/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 4
[DTOS-10199] Review apps pipeline #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
431c428 to
d6cca43
Compare
Also ask for confirmation to execute the first bicep
The GHtoADO managed identity is used by Github actions to trigger a pipeline in Azure devops Add the RBAC role assignment for the infra keyvault Rename kvSecretUser to kvSecretsUser to avoid confusion and reflect the role name accurately Update gitleaksignore
Github action workflows and Azure devops pipelines The review app builds when the PR is labelled with "deploy" The workflows now use a Github environment for each separate environment configuration, i.e. 'review' and 'dev' as opposed to 'azure'. Each one contains the secrets required for each ADO pipeline. The ADO pipeline now runs for only one environment as opposed to a list of environments. And it accepts a pull request number for review apps.
Github action workflow and Azure devops pipeline Triggered when the pull request is closed or merged. Tries to run terraform destroy if the PR has a "deploy" label.
Ensure: - 2 deployments don't run at the same time on the same environment - deploy and destroy a review app don't run at the same time
Fails the Github action workflow explicitly if Azure devops pipeline fails
a0fc197 to
081c806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira link
Review notes