[DTOS-10199] Review apps pipeline #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The review app is available at this URL: |
Also ask for confirmation to execute the first bicep
The GHtoADO managed identity is used by Github actions to trigger a pipeline in Azure devops Add the RBAC role assignment for the infra keyvault Rename kvSecretUser to kvSecretsUser to avoid confusion and reflect the role name accurately Update gitleaksignore
Github action workflows and Azure devops pipelines The review app builds when the PR is labelled with "deploy" The workflows now use a Github environment for each separate environment configuration, i.e. 'review' and 'dev' as opposed to 'azure'. Each one contains the secrets required for each ADO pipeline. The ADO pipeline now runs for only one environment as opposed to a list of environments. And it accepts a pull request number for review apps.
Github action workflow and Azure devops pipeline Triggered when the pull request is closed or merged. Tries to run terraform destroy if the PR has a "deploy" label.
Ensure: - 2 deployments don't run at the same time on the same environment - deploy and destroy a review app don't run at the same time
Fails the Github action workflow explicitly if Azure devops pipeline fails
saliceti
force-pushed
the
DTOS-10199-review-apps-pipeline
branch
from
ee225c4 to
0af2db4
Compare
saliceti
force-pushed
the
DTOS-10199-review-apps-pipeline
branch
from
0af2db4 to
aa7f96b
Compare
saliceti
force-pushed
the
DTOS-10199-review-apps-pipeline
branch
from
aa7f96b to
e326390
Compare
saliceti
force-pushed
the
DTOS-10199-review-apps-pipeline
branch
from
e326390 to
3a5b238
Compare
josielsouzanordcloud
approved these changes
Aug 19, 2025
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow deploy a review app for each pull request. It's an opt-in feature, triggered when the
deploylabel is added to the PR.It triggers github actions and azure devops to create the review app.
The URL is displayed as a PR comment.
When the PR is merged or closed, the review app is deleted.
There are now detailed infrastructure docs in
docs/infrastructure.Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10199
Review notes
Try closing and opening the PR to create/delete the app
Check pipelines in Github actions and Azure devops
Validate the new documentation
After merge
Check the dev environment