Add notifications container app jobs terraform#349
Merged
Conversation
steventux
changed the title
steventux
force-pushed
the
add-notifications-jobs-terraform
branch
from
8674bfb to
5e37067
Compare
steventux
changed the title
steventux
force-pushed
the
add-notifications-jobs-terraform
branch
2 times, most recently
from
72691cd to
47f9310
Compare
mrlockstar
force-pushed
the
add-notifications-jobs-terraform
branch
from
d6b9936 to
e4f0f96
Compare
Adds container app job module configuration for Django Admin commands necessary to import and process NBSS MESH data and make batch requests to NHS Notify.
These don't vary per environment.
mrlockstar
force-pushed
the
add-notifications-jobs-terraform
branch
from
e4f0f96 to
e6af7b7
Compare
steventux
force-pushed
the
add-notifications-jobs-terraform
branch
from
7a7492c to
65ed418
Compare
Improve the definition of environment variables for other jobs. Expose the MI client IDs in the environment as these will be needed for connectivity to storage.
steventux
force-pushed
the
add-notifications-jobs-terraform
branch
from
65ed418 to
39a2a9b
Compare
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
temporarily deployed
to
review
GitHub Actions
Inactive
|
The review app at this URL has been deleted: |
steventux
requested review from
Harriethw,
dnimmo,
josielsouzanordcloud,
mrlockstar and
saliceti
josielsouzanordcloud
approved these changes
Sep 11, 2025
dnimmo
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Private Beta breast screening appointment notifications rely on a series of Container App Jobs (CA Jobs) to process incoming data from MESH, save to the database and send to NHS Notify.
Azure Blob Storage and Azure Queue Storage are used in various places by the CA Jobs to process data. Postgresql connectivity to the Manage database is also required.
This PR adds the Terraform definitions for the CA Jobs.
A lot of the work here was done by @josielsouzanordcloud and @mrlockstar thank you for all the help with managed identity, rbac role assignment and private endpoint config.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10666
Review notes
The PR intentionally disables the cron trigger config for the CA Jobs, these will be enabled once we have some further connectivity work completed in the application code. The lack of connectivity + cron triggers would only create a lot of errors on the jobs.
See https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10948