Conversation
steventux
approved these changes
Sep 10, 2025
Contributor
steventux
left a comment
steventux
left a comment
There was a problem hiding this comment.
🚢 Nice one for using all available episode types 🥇
Harriethw
force-pushed
the
DTOSS-10865-improve-send-message-batch-tests
branch
2 times, most recently
from
bfc29d4 to
e58180a
Compare
and routing plans.
Harriethw
force-pushed
the
DTOSS-10865-improve-send-message-batch-tests
branch
from
e58180a to
14fa669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(and routing plans)
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10865
Description
I've gone with iterating through all the routing plans rather than hard coding the values we would expect, as that is covered by unit tests - this should give us confidence that it's wired together correctly?
Jira link
Review notes