Only send notifications on working days#383
Merged
Conversation
steventux
force-pushed
the
send-notifications-on-working-days
branch
from
4e0cbc8 to
38b3cf8
Compare
steventux
changed the title
Harriethw
approved these changes
Sep 10, 2025
Contributor
Harriethw
left a comment
Harriethw
left a comment
There was a problem hiding this comment.
very clean! and some nice tidying up on the test
As part of adding this library the maximum python version had to be set to <4.0.0 Given there's no active development of Python 4 this doesn't seem to contentious.
Use the default working days from the business days python library to ensure we don't send message batch requests to Notify at the weekend, this reduces the chances of people receiving notifications when the BSOs are closed. We may want to define a calendar of holidays which is supported by the business days library.
steventux
force-pushed
the
send-notifications-on-working-days
branch
from
38b3cf8 to
6f03de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restricts the sending of message batches to weekdays.
Adds the ability to define a calendar of holidays although holidays dates TBC.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-10896
Review notes
I've opted for using
business-pythonas we are going to add a calendar of holidays ensuring that we only send out message batches when the BSOs are open and able to amend bookings etc.