DTOSS-10944: remove CMAPI consumer api key#384
Merged
Conversation
This no longer needs to be sent in the headers of batch requests as it was used by CMAPI: https://github.com/NHSDigital/dtos-communication-management We should now be calling NHS Notify direct
Harriethw
force-pushed
the
DTOSS-10944-remove-CMAPI-consumer-key
branch
from
70b341d to
6bc3bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This no longer needs to be sent in the headers of batch requests as it was used by CMAPI
We should now be calling NHS Notify direct.
DTOSS-10944
(NOTE: for integration tests to pass locally you need to re-build the notify-api-stub container)
Review notes