Skip to content

Conversation

@cameronhargreaves1-nhs
Copy link
Contributor

@cameronhargreaves1-nhs cameronhargreaves1-nhs commented Oct 16, 2025

Description

Bug regarding overnight errors seemingly has been fixed due to TIME_ZONE changes. This ticket adds a test to make sure the error is not still happening. Freezes time and replicates what caused the error, but asserts both appointments get covered.

Jira link

Review notes

@cameronhargreaves1-nhs cameronhargreaves1-nhs changed the title testing wip [DTOSS-11040] Add test to make sure overnight bug is fixed Oct 22, 2025
@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11040-nighttime-test-bug-fix branch from 73ed93a to 409d698 Compare October 22, 2025 11:21
@cameronhargreaves1-nhs cameronhargreaves1-nhs marked this pull request as ready for review October 22, 2025 11:26
@cameronhargreaves1-nhs cameronhargreaves1-nhs requested a review from a team October 22, 2025 11:26
@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11040-nighttime-test-bug-fix branch from 9964c19 to 6de8df3 Compare October 22, 2025 11:33
@cameronhargreaves1-nhs cameronhargreaves1-nhs force-pushed the DTOSS-11040-nighttime-test-bug-fix branch from 6de8df3 to 3433ae8 Compare October 22, 2025 11:46
Copy link
Contributor

@steventux steventux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a good clean test around daylight saving.

@cameronhargreaves1-nhs cameronhargreaves1-nhs merged commit 67a27f9 into main Oct 22, 2025
12 checks passed
@cameronhargreaves1-nhs cameronhargreaves1-nhs deleted the DTOSS-11040-nighttime-test-bug-fix branch October 22, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants