Order view decorators so that basic_auth_exempt works as expected #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a side-effect to ordering the basic_auth_exempt decorator after the csrf_exempt or require_http_methods decorators so work around this with a working order for now.
malcolmbaig
approved these changes
Oct 21, 2025
Contributor
|
Thanks @steventux 👍🏼 . |
Contributor
Author
|
Closing in favour of #576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a side-effect to ordering the
basic_auth_exemptdecorator after thecsrf_exemptorrequire_http_methodsdecorators. Basic auth will not be skipped.Work around this with a working order for now.
Jira link
See https://screening-discovery.slack.com/archives/C08R0BT5HH6/p1760623960488199
Review notes