DTOSS-11003: use HTML templates for report emails #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
commented
Oct 16, 2025
| decoded_attachment_data = base64.b64encode(csv_data.encode("utf-8")).decode( | ||
| "utf-8" | ||
| decoded_attachment_data = ( | ||
| mime_message.get_payload()[1] # type: ignore |
Contributor
Author
There was a problem hiding this comment.
really delving deep into the complexities of email types... happy to take any suggestions if there's a simpler way of decoding 😅
Contributor
There was a problem hiding this comment.
I'm probably lacking a bit of context here but there's an iter_attachments method on email.message which might be a cleaner way to obtain the right part. Given this is a test I wouldn't be too concerned about the current code though.
Harriethw
force-pushed
the
DTOSS-11003-email-content
branch
from
693cca0 to
b81cc1c
Compare
Harriethw
force-pushed
the
DTOSS-11003-email-content
branch
from
b81cc1c to
a9a0393
Compare
cameronhargreaves1-nhs
approved these changes
Oct 17, 2025
Contributor
cameronhargreaves1-nhs
left a comment
cameronhargreaves1-nhs
left a comment
There was a problem hiding this comment.
nice changes on this! 🔥
this makes it easier to format and pass in variables than one long string. Outlook, the NHS email service provide, should always support HTML in emails.
Harriethw
force-pushed
the
DTOSS-11003-email-content
branch
from
a9a0393 to
3023168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it easier to format and pass in variables than one long string.
Outlook, the NHS email service provide, should always support HTML in emails.
(exact copy of emails is still pending)
Description
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11003
Review notes