DTOSS-11239: Add App. Insights to Create Report job #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
approved these changes
Oct 20, 2025
| ) | ||
| self.create_reports(options) | ||
| except Exception as e: | ||
| ApplicationInsightsLogging().exception(f"{INSIGHTS_ERROR_NAME}: {e}") |
Contributor
There was a problem hiding this comment.
Do we also need to log an exception and stack trace here? Perhaps already missing from this command. I'm just trying to identify if there is a pattern of:
logger.exception("Something bad", exc_info=True)
ApplicationInsightsLogging().exception(f"TheError: {e}")
raise CommandError(e)in every command and if so how we could roll this up into one distinct contextmanager like:
with CommandExceptionHandler():
do_some_stuff()
do_more()
and_some_more()And CommandExceptionHandler would do the logging, AppInsights logging and reraise the exception.
Just an idea and not for this PR
Contributor
Author
There was a problem hiding this comment.
Logging to the Application Insights Logger also logs to stdout so there's no need to duplicate calls like that, afaik
Contributor
Author
There was a problem hiding this comment.
but otherwise yep could bundle it all into some kind of shared wrapper!
As with the Retry command, this ensures any exceptions thrown by job will be caught.
to make it clearer that everything is in try/catch block
Harriethw
force-pushed
the
DTOSS-11239-create-report-monitoring
branch
from
e2d1ef9 to
001da38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow the pattern set out with the Retry and Create Appt. command,
this ensures that any exceptions are captured by
Insights and we can monitor and alert on them.
Happy to go through the Insights UI to show how this feeds through, and there's more context on Jira
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11239
Review notes