Small improvements to Makefile #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Collect the includes, default goal, .PHONY, and .SILENT directives at the top so file metadata is easy to spot - Split the targets into clear sections (Help, Cleaning, Bootstrap, Development, Testing, Build) with divider comments - Expanded the .PHONY list to cover all non-file targets
- Include a new make target for running the personas command - Run both personas and seed-demo-data when calling `make local`
Update the configured local environment rather than just running the db. This will make sure that dependency updates and asset compilation happen as well.
MatMoore
reviewed
Oct 22, 2025
| build: # Build the project artefact @Pipeline | ||
| docker build -t "app:$$(git rev-parse HEAD)" . | ||
|
|
||
| deploy: # Deploy the project artefact to the target environment @Pipeline |
Contributor
MatMoore
approved these changes
Oct 22, 2025
Makefile
Outdated
| docker compose --env-file manage_breast_screening/config/.env up -d --wait | ||
|
|
||
| local: db run | ||
| local: db seed-demo-data personas run |
Contributor
There was a problem hiding this comment.
can we also use seed-demo-data and personas in the rebuild-db task as well? It's for deleting the db volume and rebuilding in cases where the DB is messed up.
seed does nothing and I don't think we need it anymore
Have this execute seed-demo-data and personas. Remove seed as we don't currently have a use for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make localcommandmake localJira link
na
Review notes
na