fix parameter name in checkout action #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
either this has never worked, or the param changed, but currently this is being ignored, meaning only the latest commit is scanned. The intention here was to scan all anscestor commits of the current branch. note: the entire git history is still scanned on main
MatMoore
force-pushed
the
fix-pr-level-secret-scan
branch
from
5279738 to
f5e5e7d
Compare
malcolmbaig
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the change we made in #280 in order to avoid secret scanning blocking our PR workflow.
Either this has never worked, or the param changed, but currently the
depthparam is being ignored, meaning only the latest commit is checked out as part of the CI. However, the intention here was to fetch all ancestor commits of the current branch (but not the entire repository) so that secret scanning is able to scan every commit in the PR.After fixing the param, I tested this by pushing two commits: first one with a fake credential in, second one that removes the credential. It correctly failed the check.
Note: regardless of what this PR check is doing, the entire git history is still scanned on main, so secrets cannot slip through without us being alerted.