Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cicd-1-pull-request-closed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
--parameters commitSHA=${{ github.event.pull_request.head.sha }} prNumber=${{ github.event.pull_request.number }} \
--output tsv --query id)

echo "See pipeline run in Azure devops: https://dev.azure.com/nhse-dtos/dtos-manage-breast-screening/_build/results?buildId=${RUN_ID}&view=results"

scripts/bash/wait_ado_pipeline.sh "$RUN_ID" https://dev.azure.com/nhse-dtos dtos-manage-breast-screening

- name: Post URL to PR comments
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cicd-1-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,4 @@ jobs:
message: |
The review app is available at this URL:
https://pr-${{ github.event.pull_request.number }}.manage-breast-screening.non-live.screening.nhs.uk
You must authenticate with Entra ID
You must authenticate with HTTP basic authentication. Ask the team for credentials.
2 changes: 1 addition & 1 deletion infrastructure/terraform/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@ module "container-apps" {
infra_key_vault_rg = local.infra_key_vault_rg
api_oauth_token_url = var.api_oauth_token_url
nhs_notify_api_message_batch_url = var.nhs_notify_api_message_batch_url
target_url = var.deploy_container_apps ? "${module.container-apps[0].external_url}healthcheck/" : null
target_url = var.deploy_container_apps ? "${module.container-apps[0].external_url}healthcheck" : null
resource_group_name_infra = local.resource_group_name
}
5 changes: 3 additions & 2 deletions manage_breast_screening/core/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def sha_view(request):
@basic_auth_exempt
@login_not_required
def health_check(request):
return HttpResponse("OK")
return HttpResponse("OK")


urlpatterns = [
path(
Expand All @@ -44,7 +45,7 @@ def health_check(request):
"clinics/", include("manage_breast_screening.clinics.urls", namespace="clinics")
),
path(
"healthcheck/",
"healthcheck",
health_check,
),
path(
Expand Down
Loading