Breast cancer history add form #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
changed the base branch from
main
to
dtos-114466-add-breast-cancer-history
Base automatically changed from
dtos-114466-add-breast-cancer-history
to
main
November 13, 2025 09:27
MatMoore
force-pushed
the
dtos-114466-add-breast-cancer-history-2
branch
3 times, most recently
from
9f29c1e to
a4a2379
Compare
MatMoore
changed the title
MatMoore
force-pushed
the
dtos-114466-add-breast-cancer-history-2
branch
from
aedeebe to
c0b34a4
Compare
|
The review app at this URL has been deleted: |
swebberuk
reviewed
Nov 24, 2025
| if explicitly_set_html: | ||
| return explicitly_set_html | ||
|
|
||
| if isinstance(self.form, FormWithConditionalFields): |
Contributor
There was a problem hiding this comment.
Looks good to me. Just to check I've understood it correctly, I think this is to avoid us having to add to breast_cancer_history_item_form.jinja lines like:
{% do form.systemic_treatments.add_conditional_html('OTHER', form.systemic_treatments_other_treatment_details.as_field_group()) %}
The design system radios and checkboxes components take a "conditional" param when defining the options. This allows you to add arbitrary html that is conditionally shown when the option is selected. Now that we have FormWithConditionalFields, we can declare the relationships between conditionally dependent fields. This commit extends that so that the conditional param is generated based on those declarations, so you don't need to explicitly tell the field what the conditional html is in the template. The old method for setting arbitrary html is still there in case we need it for more complex cases, where we might want to conditionally show more than just a simple field.
There are two new patterns here for arranging checkboxes and radios into a grid. This is because we want to show options relating to the right breast on the left and left breast on the right, to match the perspective of the mammographer facing the participant. In one case, we are treating right breast and left breast as separate fields, and rendering them side by side. Both fields have their own legends and are validated independently. In the other case, we model the question as a single field and we just arrange the options. We implement this by calling the component twice for the same field, but passing in different options.
The design system checkboxes component allows marking options as exclusive, meaning they toggle all the other options off when selected.
MatMoore
force-pushed
the
dtos-114466-add-breast-cancer-history-2
branch
from
c0b34a4 to
3ae8884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the form for adding breast cancer history.
This one has multiple questions that are presented in a 2 column layout.
The year field is not done yet - waiting for #739 to be merged and then I'll rebase.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11446
Review notes
Review checklist