make systemic_treatments an ArrayField #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
dtos-114466-fix-systemic-treatments
branch
from
5663a8f to
24c997b
Compare
swebberuk
reviewed
Nov 19, 2025
manage_breast_screening/data/east_tester_one_week_ago_clinic_data.yml
Outdated
Show resolved
Hide resolved
MatMoore
force-pushed
the
dtos-114466-fix-systemic-treatments
branch
from
24c997b to
048bf3c
Compare
malcolmbaig
reviewed
Nov 19, 2025
| validators=[ | ||
| ExcludesOtherOptionsValidator( | ||
| SystemicTreatment.NO_SYSTEMIC_TREATMENTS.label, | ||
| SystemicTreatment.NO_SYSTEMIC_TREATMENTS.label, |
MatMoore
force-pushed
the
dtos-114466-fix-systemic-treatments
branch
from
048bf3c to
23728d3
Compare
We actually want to allow multiple options for this.
MatMoore
force-pushed
the
dtos-114466-fix-systemic-treatments
branch
from
23728d3 to
56899b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This field is supposed to be an ArrayField. On the form to add breast screening history, it's going to be a set of checkboxes, with an exclusive "No systemic treatments" option so that the user can explicitly mark when there are no systemic treatments. This will match how we're handling the treatments associated with right/left breast.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11446
Review notes
Please double check the arguments to ArrayField, and that the migration works ok. 🙏🏻
Review checklist