Merge aggregate and reconciliation reports #732
Conversation
steventux
force-pushed
the
merge-aggregate-and-reconciliation-reports
branch
from
68aebcc to
a886e81
Compare
| GROUP BY clin.code, appt.episode_type, appt.status | ||
| SELECT appt.nhs_number::text AS "NHS number", | ||
| clin.name || ' (' || clin.code || ')' AS "Clinic name and code", | ||
| CASE |
| df(now, 7), | ||
| df(now, 7), | ||
| df(now, 7), | ||
| None, |
There was a problem hiding this comment.
I'm starting to get a bit overwhelmed by the range of data/columns and it's hard to parse without seeing the actual file outputted.... and I've actually never seen a report with "real" data in it 😬
do you think an integration test would be useful? if only to provide an easy way to populate data and run locally 🤔
There was a problem hiding this comment.
Agree, this didn't feel great when I was refactoring. I think I can make the test a bit clearer than this. Probably being a bit lazy in how I am comparing the results to the expectations, will amend.
There was a problem hiding this comment.
@Harriethw I've tried to make the test assertions clearer and reduced the test data to the smallest possible selection of data.
There was a problem hiding this comment.
Regarding realistic end reports, I wonder if there is something we can do when we come to load testing around this, we will be creating a large data import for load testing which could help us generate realistic reports.
|
This looks good! I think it just needs rebasing against main to get rid of the first three commits? |
steventux
force-pushed
the
merge-aggregate-and-reconciliation-reports
branch
2 times, most recently
from
4722d0c to
460cdda
Compare
steventux
force-pushed
the
merge-aggregate-and-reconciliation-reports
branch
from
460cdda to
412a8e7
Compare
2 participants
Description
Refactors the reconciliation report to give detail on all appointments for the given period. Notifications timestamps and some additional status information is included.
(This image does not contain real data)
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11604
Review notes
Review checklist