Send notification reports in one email #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor how we determine how to send email.
Only send one email containing all external reports.
Harriethw
reviewed
Nov 18, 2025
| logger.info("Report %s created", report_config.report_filename) | ||
| logger.info("Report %s created", report_config.name) | ||
|
|
||
| if not options.get("smoke_test", False): |
Contributor
There was a problem hiding this comment.
maybe my not getting it, but should we keep the logic behind sending an email to one thing, e.g the report_config.send_email boolean? otherwise we check two different things for whether to send an email?
Or can we get rid of report_config.send_email and only check whether it's a smoke test or not?
Contributor
Author
There was a problem hiding this comment.
I think you're right, this check isn't necessary anymore. I'll make sure the tests cover the smoke test config adequately.
Contributor
Author
There was a problem hiding this comment.
@Harriethw thanks for catching that 0a41866
Harriethw
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently send an email per generated report, we don't currently need this granularity.
This PR:
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11604
Review notes
Review checklist