Do not download report at end of smoke test #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a potential security issue with the ADO pipeline having permissions to download a report from blob storage. There are alternatives to this approach like searching logs which can be used to verify the smoke test. As an interim step, do not download the smoke test report, simply verify that all container app jobs ran sucessfully.
josielsouzanordcloud
approved these changes
Nov 20, 2025
|
The review app at this URL has been deleted: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a potential security issue with the ADO pipeline having permissions to download a report from blob storage.
For this reason we don't enable these perms on dev, preprod and prod but for some reason review env granted this.
The smoke test was downloading the smoke test report from blob storage in the final verification step and this probably should not happen.
There are alternatives to this approach like searching logs which can be used to verify the smoke test.
As an interim step, do not download the smoke test report, simply verify that all container app jobs ran successfully.
Jira link
Review notes
Review checklist