Eval and export ENVIRONMENT var #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Make
Harriethw
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of fixing notification smoke tests across all environments (see https://screening-discovery.slack.com/archives/C07QHFSV79U/p1763636686675789)
Make doesn't seem to export variables in the same way as a plain bash script so wrap export in
$(eval export ENVIRONMENT=${ENVIRONMENT})as this seems to work elsewhere in the MakefileJira link
https://screening-discovery.slack.com/archives/C07QHFSV79U/p1763636686675789
Review notes
Review checklist