Add mastectomy or lumpectomy history form #754
Conversation
swebberuk
force-pushed
the
DTOSS-11452-mastectomy-and-lumpectomy
branch
2 times, most recently
from
bd63fb1 to
c657e2a
Compare
swebberuk
force-pushed
the
DTOSS-11452-mastectomy-and-lumpectomy
branch
4 times, most recently
from
b2d3bdc to
441eb64
Compare
| classes="nhsuk-input--width-4", | ||
| min_value=datetime.date.today().year - 80, | ||
| max_value=datetime.date.today().year, | ||
| error_messages={ |
There was a problem hiding this comment.
Will replace this with YearField once #739 has been merged, so won't need to specify error messages.
swebberuk
force-pushed
the
DTOSS-11452-mastectomy-and-lumpectomy
branch
from
441eb64 to
ee4eeb9
Compare
| {% block form %} | ||
| <p> | ||
| This is designed to capture information on prophylactic or elective surgery. | ||
| <a href="../breast-cancer-history/" class="nhsuk-link"> |
There was a problem hiding this comment.
Don't know if href="../breast-cancer-history/" is the best way to refer to the "Add details of breast cancer" page? Should I be using medical_information_presenter.py add_breast_cancer_history_link instead?
There was a problem hiding this comment.
Yeah I think that would be better. The method is already implemented, and looking up all the routes via reverse means the tests will check that the links are actually going somewhere.
swebberuk
changed the title
swebberuk
force-pushed
the
DTOSS-11452-mastectomy-and-lumpectomy
branch
from
ee4eeb9 to
64f1894
Compare
MatMoore
left a comment
MatMoore
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple of minor things
|
|
||
| assert form.is_valid() | ||
|
|
||
| existing_log_count = AuditLog.objects.count() |
There was a problem hiding this comment.
This test is doing quite a lot of verification... I'm wondering if it's worth doing quite so much querying of the database state in our tests as it's going to slow down the runtime of the test suite.
I previously added a similar test to this audit log bit for something else, but we decided in review to drop it, and spoke about adding some kind of static analysis check instead. I haven't had a go at that yet but think we should probably leave it out here as well.
| self.when_i_click_on_add_mastectomy_or_lumpectomy() | ||
| self.then_i_see_the_add_mastectomy_or_lumpectomy_form() | ||
|
|
||
| self.and_i_click_save() |
There was a problem hiding this comment.
very minor, but the "and" here breaks the pattern slightly. Could we add in an alias for the step so it reads more naturally?
Added "Add details of mastectomy or lumpectomy" page which can be accessed from the "Record medical information" page.
swebberuk
force-pushed
the
DTOSS-11452-mastectomy-and-lumpectomy
branch
from
ff504df to
8eaef2c
Compare
2 participants
work in progress, not yet ready for review
Added "Add details of mastectomy or lumpectomy" page which can be accessed from the "Record medical information" page.
Description
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11452
Review notes
Review checklist