Make 'Year removed' optional for 'Implanted device has been removed' #761
Conversation
swebberuk
changed the title
swebberuk
force-pushed
the
DTOSS-11720-year-removed-optional
branch
3 times, most recently
from
21ed1a2 to
c037265
Compare
swebberuk
changed the title
| ) | ||
|
|
||
|
|
||
| class TestYearField: |
There was a problem hiding this comment.
Added TestYearField. This will be provided by #739 once it has been merged to main and this branch rebased.
swebberuk
force-pushed
the
DTOSS-11720-year-removed-optional
branch
from
c037265 to
2891f9c
Compare
manage_breast_screening/mammograms/forms/implanted_medical_device_history_form.py
Outdated
Show resolved
Hide resolved
| return implanted_medical_device_history | ||
|
|
||
| def full_clean(self): | ||
| # if a removal_year is provided then remove it if device_has_been_removed is False |
There was a problem hiding this comment.
I wonder if FormWithConditionalFields should have a way of handling this use case too (i.e. declaring that a field should only be parsed in a certain case, even if it is not required to pass a value) 🤔
There was a problem hiding this comment.
I agree that could be useful. Should I create a ticket in the backlog to investigate that? I don't want it to be a requirement of merging this PR, as these changes are required for DTOSS-11528 (updating implanted medical device history).
There was a problem hiding this comment.
Yeah that would be great, don't let it block this work 👍🏻
swebberuk
force-pushed
the
DTOSS-11720-year-removed-optional
branch
from
b55e90a to
1fc4158
Compare
malcolmbaig
changed the title
swebberuk
force-pushed
the
DTOSS-11720-year-removed-optional
branch
from
1fc4158 to
93033e4
Compare
swebberuk
force-pushed
the
DTOSS-11720-year-removed-optional
branch
from
93033e4 to
559353e
Compare
2 participants
Description
On the "Add details of implanted medical device" page make "Year removed" optional for "Removed implants"/"Implanted device has been removed".
This is to make it consistent with "Removed devices"/"Implants have been removed" on the "Add details of breast implants or augmentation" page.
Making this change in preparation for DTOSS-11528 (update implanted medical device history).
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11720
Review notes
Review checklist