Breast augmentation form uses YearField #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
approved these changes
Nov 25, 2025
| min_year = max_year - 80 | ||
| year_outside_range_error_message = ( | ||
| f"Year should be between {min_year} and {max_year}." | ||
| self.create_year_outside_range_error_messsage(procedure_year) |
Contributor
There was a problem hiding this comment.
I think I preferred this as it was, rather than extracting a helper, as it's easier to see what's being asserted
Contributor
Author
There was a problem hiding this comment.
Okay, have reverted back to how it was. Have removed create_year_outside_range_error_messsage.
swebberuk
force-pushed
the
DTOSS-11723-breast-augmentation-year-field
branch
from
d7d8249 to
941eb13
Compare
malcolmbaig
changed the title
malcolmbaig
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alter breast augmentation form to use
YearField.Also added
visually_hidden_label_prefix/visually_hidden_label_suffixto procedure fields, to be consistent with other forms.Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11723
Review notes
Review checklist