fix: add enable_alerting variable to infra #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
fix-insights-variable
branch
from
ea0a5cf to
226744d
Compare
Harriethw
requested review from
josielsouzanordcloud,
mrlockstar and
steventux
and removed request for
mrlockstar
Harriethw
force-pushed
the
fix-insights-variable
branch
from
b8bf45a to
7da25d1
Compare
Harriethw
force-pushed
the
fix-insights-variable
branch
from
7da25d1 to
6d230b5
Compare
Harriethw
force-pushed
the
fix-insights-variable
branch
from
6d230b5 to
d0f80db
Compare
Harriethw
added a commit
that referenced
this pull request
Nov 26, 2025
This variable needs correct setup to work - we will set it up correctly in a review app [1] and then merge #774
1 task
Harriethw
force-pushed
the
fix-insights-variable
branch
from
d0f80db to
4407685
Compare
|
The review app is available at this URL: |
This is set in variables.tfvars and is needed to decide whether alerting on the app-insights module is setup (in infrastructure/modules/app-insights/alerts.tf on the dtos-devops-templates repo)
Harriethw
force-pushed
the
fix-insights-variable
branch
from
4407685 to
368ac06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is set in variables.tfvars and is needed to
decide whether alerting on the app-insights module is setup (in infrastructure/modules/app-insights/alerts.tf on the dtos-devops-templates repo)
I've also changed the original documentation string because it's a variable used in several different places now, not just for postgres
Jira link
Review notes
Review checklist