Medical history - update implants and augmentation #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
DTOSS-11524-update-implants-and-augmentation
branch
from
3e5b8e3 to
3d4dea8
Compare
swebberuk
reviewed
Nov 27, 2025
|
|
||
|
|
||
| class BreastAugmentationHistoryForm(Form): | ||
| class BreastAugmentationHistoryBaseForm(Form): |
Contributor
There was a problem hiding this comment.
This approach, to have a BaseForm and separate add and update forms, is the same as has been done in #760 and #770. For some forms - e.g. #778 - we've instead combined the add and update functionality into a single form. If we can agree on what approach is best then I can review all the forms and make them consistent.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I don't have a strong opinion either way. Initially I did the combined approach but thought it was a bit weird that the constructor param was required or not depending on what method you call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the update form for breast implants and augmentations.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-11524
Review notes
I've just copied the same pattern from the other medical history forms.
Review checklist