Improve linter by switching from deny listing to allow listing #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
reviewed
Dec 1, 2025
scripts/lint_model_usage_in_views.py
Outdated
| "CystHistoryItem", | ||
| "ImplantedMedicalDeviceHistoryItem", | ||
| "MastectomyOrLumpectomyHistoryItem", | ||
| "ParticipantReportedMammogram", |
Contributor
There was a problem hiding this comment.
Worth putting a comment here to indicate that these last five items are temporarily allowlisted.
MatMoore
force-pushed
the
improve-linter
branch
from
2c9d1b0 to
44fdc0f
Compare
malcolmbaig
approved these changes
Dec 3, 2025
This ensures the linter will catch violations on newly added models.
MatMoore
force-pushed
the
improve-linter
branch
from
44fdc0f to
73e8c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on something else, I noticed this linter failed to catch existing issues with related objects. This PR switches from deny listing to allow listing so that it lints new model calls by default, and it's explicit what we're ignoring.
In future commits we can properly scope these models:
Jira link
Review notes
Review checklist